[savannah-help-public] [sr #109487] Lost password link redirects to home page (confusingly)

[Carlo Zancanaro]

URL:
<http://savannah.gnu.org/support/?109487>

Summary: Lost password link redirects to home page
(confusingly)
Project: Savannah Administration
Submitted by: czan
Submitted on: Tue 03 Apr 2018 10:56:06 PM UTC
Category: Savannah website
Priority: 5 - Normal
Severity: 1 - Wish
Status: None
Assigned to: None
Originator Email:
Operating System: GNU/Linux
Open/Closed: Open
Discussion Lock: Any

_______________________________________________________

Details:

I noticed that after I reset my password it returned me to
https://savannah.gnu.org (ie. the root page), while leaving me logged out.
This was slightly confusing, as I wasn't sure if I had been logged in or not.

I think it would make more sense to redirect to the login page (or to
automatically log the user in).

From a brief look at the source, changing
lostlogin.php
<https://git.savannah.gnu.org/cgit/administration/savane.git/tree/frontend/php/account/lostlogin.php>
on line 56 to add "account/login.php" might do it.




_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/support/?109487>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/

[Bob Proulx]

Follow-up Comment #1, sr #109487 (project administration):

I just tried the lost password recovery and I agree that it is less than nice
the way it is working now. Thank you for your patch suggestion. You have
distinguished yourself!

I tried your suggestion however and something else seems to be needed as that
line does not seem to be the line that is executed upon lost password
recovery. I might be getting confused by something however such as some cache
that I haven't flushed. I will need to dig deeper.

In any case I made your suggested change (with a slight modification) as a
test to try it out to line 56 (actually 51 in Assaf's "agn/test2" branch
currently being run) and it didn't get executed.

session_redirect("https://savannah.gnu.org/account/login.php");

The session_redirect routine is a thin wrapper around sending the Location:
header and exiting as one might expect. As such it needs to be a full URL.
Yet when I tried to trigger the behavior I was redirected back to the root
page and not to the login page. Huh? And so now I don't know if this was an
incorrect test on my part or if something else is happening. Your suggested
patch seems to be in the right place. I'll keep looking. But I wanted to
encourage you as your suggestion seems spot on.

This also reminds us that the branch needs to be updated and merged back into
master.



_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/support/?109487>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/